⚡ Bolt: Optimize Rule workspace name normalization#98
⚡ Bolt: Optimize Rule workspace name normalization#98google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
💡 What: Replaced `String.replaceAll("[.-]", "_")` with a pre-compiled Guava `CharMatcher`.
🎯 Why: `replaceAll` recompiles the regex pattern on every call, which is expensive in hot paths.
📊 Impact: Reduces overhead for name normalization, which scales with the number of dependencies.
🔬 Measurement: Verified with `bazel test //resolver:rule_test`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This PR optimizes
Rule.javaby using Guava'sCharMatcherinstead ofString.replaceAllfor normalizing workspace names. This avoids repeated regex compilation. A new testRuleTest.javais added to verify the behavior.PR created automatically by Jules for task 14472985666704018592 started by @menny